Skip to content

Graceful error handling when calling code host apis #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

brendan-kellam
Copy link
Contributor

@brendan-kellam brendan-kellam commented Dec 19, 2024

The following adds graceful error handling for code host api calls. When a api call fails, an error message is raised and the config synchronization continues. Fixes #140

The side-effect of this is that if an api experiences some transient error (e.g., network issue, rate limits, etc.), then repositories will be marked stale when they actually are not. If autoDeleteStaleRepos is enabled, then the repo & it's index will be deleted.

Two things we can do come to mind:

  1. We add a delay between when a repo is marked stale and when it is deleted. This way, it gives the config a change to be re-synced again (and the transient issues gone).
  2. We add retry mechanisms to api calls s.t., we retry on known failures.

@brendan-kellam brendan-kellam merged commit 03aa608 into main Dec 19, 2024
3 checks passed
@brendan-kellam brendan-kellam deleted the bkellam/error_handling branch December 19, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hangs at first error (GitLab group innaccessible)
1 participant