Add support for configurable domain sub-paths #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
brendan-kellam
changed the title
|
Going to give it a go now |
brendan-kellam
force-pushed
the
bkellam/base_path
branch
from
7cb0f8f to
9244df4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the runtime environment variable
DOMAIN_SUB_PATHthat allows for configuration of what domain subpath Sourcebot will serve from. For example, ifDOMAIN_SUB_PATH=/bot, the Sourcebot will serve from the endpointhttp(s)://example.com/bot. This is useful for certain reverse proxy scenarios.Under the hood, this is configuring the basePath parameter in the
next.config.mjs. Unfortunately,basePathis not normally configurable at runtime, so I had to add moreBAKED_+ find&replace trickery outlined in this blog.Fixes #61