Saas relder csrf delete file #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asantoni
pushed a commit
that referenced
this pull request
Oct 29, 2014
|
I merged this into cc-5709-airtime-analyzer and then across to the branches based on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of refactoring to build CSRF verification into all routes in /rest/media. To my knowledge, we're only using session based authentication in the delete and upload routes currently (there are a number of others).
I also added a prefix of baseUrl to the url because our other branch adds baseDir for this API call. I'm not sure if baseUrl and baseDir are interchangable, but baseDir is not defined here. Tested with deletion and it works.