feat(tenant-management): integrate multiple idps #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyagi-Sunny
commented
Oct 7, 2024
Tyagi-Sunny
commented
Oct 7, 2024
| description: 'Tenat object', | ||
| jsonSchema: getJsonSchema(Object), | ||
| }) | ||
| tenant: AnyObject; |
There was a problem hiding this comment.
why are we giving tenant as AnyObject
Tyagi-Sunny
commented
Oct 7, 2024
Tyagi-Sunny
commented
Oct 7, 2024
| @@ -0,0 +1,4 @@ | |||
| export type Auth0Response = { | |||
There was a problem hiding this comment.
as we are using a commong resp IdpResp={authId:string}, we can remove this Auth)response
Tyagi-Sunny
commented
Oct 7, 2024
yeshamavani
requested changes
Oct 17, 2024
services/tenant-management-service/src/providers/idp/idp-auth0.provider.ts
Outdated
Show resolved
Hide resolved
Tyagi-Sunny
force-pushed
the
GH-47
branch
3 times, most recently
from
ab1adcb to
ec347b9
Compare
Surbhi-sharma1
force-pushed
the
GH-47
branch
3 times, most recently
from
884e319 to
eeee31c
Compare
|
integrate multiple idps 47
remove sonar issues 47
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: