Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Sequelize as base repository from loopback4-sequelize package #118

Closed
shubhamp-sf opened this issue Jan 18, 2023 · 1 comment · Fixed by #119
Closed

Add support for Sequelize as base repository from loopback4-sequelize package #118

shubhamp-sf opened this issue Jan 18, 2023 · 1 comment · Fixed by #119
Assignees
@shubhamp-sf
Labels
released

Comments

@shubhamp-sf
Copy link
Contributor

Problem

Potential projects utilizing loopback4-sequelize package won't be able to use soft-delete capabilities as for now, because the base here is DefaultCrudRepository which needs to be changed.

Solution

  1. Export a repository factory that can be used in place of SoftCrudRepository (from loopback4-soft-delete) but with utilizing sequelize capabilities.
  2. Export a repository factory that can be used in place of DefaultUserModifyCrudRepository (from @sourceloop/core package) but with utilizing sequelize capabilities.

Alternatives

Solution no. 2 can be also implemented in @sourceloop/core repository.
@shubhamp-sf shubhamp-sf self-assigned this Jan 18, 2023
shubhamp-sf added a commit that referenced this issue Jan 18, 2023
@shubhamp-sf
feat(sequelize): add sequelize repository support
9ba1705 
adds `sequelizeSoftCrud` function providing soft-delete capabilities
with sequelize as underlying repository

adds `sequelizeUserModifyCrudRepository` function providing
`DefaultUserModifyCrudRepository` (from `@sourceloop/core`) like capabilities
with sequelize as underlying repository

GH-118
@shubhamp-sf shubhamp-sf mentioned this issue Jan 18, 2023
Merged
7 tasks
shubhamp-sf added a commit that referenced this issue Jan 19, 2023
@shubhamp-sf
feat(sequelize): add sequelize repository support
10e7e02 
adds `sequelizeSoftCrud` function providing soft-delete capabilities
with sequelize as underlying repository

adds `sequelizeUserModifyCrudRepository` function providing
`DefaultUserModifyCrudRepository` (from `@sourceloop/core`) like capabilities
with sequelize as underlying repository

GH-118
shubhamp-sf added a commit that referenced this issue Jan 19, 2023
@shubhamp-sf
feat(sequelize): add sequelize repository support
f59472a 
Export `sequelizeSoftCrud` function providing soft-delete capabilities
with sequelize as underlying repository

Export `sequelizeUserModifyCrudRepository` function providing
`DefaultUserModifyCrudRepository` (from `@sourceloop/core`) like capabilities
with sequelize as underlying repository

GH-118
shubhamp-sf added a commit that referenced this issue Feb 28, 2023
@shubhamp-sf
feat(sequelize): add sequelize repository support
ef28616 
Export `SequelizeSoftCrudRepository` providing soft-delete capabilities with sequelize as underlying
repository

GH-118
shubhamp-sf added a commit that referenced this issue Feb 28, 2023
@shubhamp-sf
feat(sequelize): add sequelize repository support
c95947b 
Export `SequelizeSoftCrudRepository` providing soft-delete capabilities with sequelize as underlying
repository

GH-118
shubhamp-sf added a commit that referenced this issue Feb 28, 2023
@shubhamp-sf
feat(sequelize): add sequelize repository support
614b485 
Export `SequelizeSoftCrudRepository` providing soft-delete capabilities with sequelize as underlying
repository

GH-118
yeshamavani pushed a commit that referenced this issue Feb 28, 2023
@shubhamp-sf
feat(sequelize): add sequelize repository support (#119)
424c611 
Export `SequelizeSoftCrudRepository` providing soft-delete capabilities with sequelize as underlying
repository

GH-118
@sfdevops
Copy link
Contributor

🎉 This issue has been resolved in version 7.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shubhamp-sf shubhamp-sf

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(sequelize): add sequelize repository support sourcefuse/loopback4-soft-delete
2 participants
@sfdevops @shubhamp-sf