Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HotKeys for macOS #103

Closed
successgo opened this issue May 3, 2024 · 15 comments
Closed

HotKeys for macOS #103

successgo opened this issue May 3, 2024 · 15 comments
Assignees
Labels
enhancement New feature or request

Comments

@successgo
Copy link

Hi, thank you for the fantastic software.

macOS is mainly using Command other than Control like Command + T to open new page. Can we keep this convention?

@love-linger love-linger self-assigned this May 3, 2024
@love-linger love-linger added the enhancement New feature or request label May 3, 2024
love-linger added a commit that referenced this issue May 5, 2024
@love-linger
Copy link
Collaborator

I'm using hackintosh to compile and distribute this app for macOS and I do NOT have an apple keyboard to test with hotkeys. I can't guarantee that the current changes are consistent with macOS user habits.

Looking forward to your feedback.

love-linger added a commit that referenced this issue May 5, 2024
love-linger added a commit that referenced this issue May 5, 2024
@successgo
Copy link
Author

Cool, I'll check that later.

@successgo
Copy link
Author

Confirmed: CMD+W and CMD+T worked very well. I thought others should be too because I don't use them.

Thank you @love-linger

@love-linger
Copy link
Collaborator

The HotKeys from main menu shows all the hotkeys used by this app.
image

Could you help me to test these hotkeys?

@successgo
Copy link
Author

successgo commented May 6, 2024

Tested and all working fine.

But reguarding F5, while reloading done, the focus is updated to the middle of the commit history other that the top and I have to scroll to the top, did that design so?

For text editor searching:
On Chrome and Rider, Enter is for next match, and Shift + Enter is for the previous match.

Also for next page:
It would be great to use Ctrl + Tab as in windows, and it would be better to add Shift + Ctrl + Tab to go to previous page.

Also for stage / unstage:
It would be great to use Enter other than Space.

Nice to have:
On macOS, while editing there are some global shortcuts to use, like Ctrl + F to move the cursor to the right of one character and Ctrl + B do the opposite, and Ctrl + P to move the cursor to the previous line and Ctrl + N to the cursor the next line.

@love-linger
Copy link
Collaborator

  1. After reloading repository, the selected commit keeps to the last selected one. See PR fix: keep selected commit after _commits var reassigned #104
  2. It's the built-in hotkeys in AvaloniaEdit control.
  3. I'll consider to add these keys.
  4. The TreeView/ListView/DataGrid has these built-in hotkeys.

@love-linger
Copy link
Collaborator

I have just confirmed that use Enter for next match and Shift+Enter for previous match is also worked on Windows

@successgo
Copy link
Author

  1. Sorry, You are right. This is great to keep the last selected commit.

@successgo
Copy link
Author

successgo commented May 6, 2024

I have just confirmed that use Enter for next match and Shift+Enter for previous match is also worked on Windows

I just confirmed it's also working fine for macOS.

@successgo
Copy link
Author

successgo commented May 6, 2024

While digging more on searching:

  1. Search Files on CHANGES tab does not support shortcut, like Ctrl + F on windows and Command + F on macOS.
  2. Search commits and search text, both are using Ctrl + F to invoke, but cancel searching is using different approach, it will be better to keep consistence, ESC to cancel would be good.

@love-linger
Copy link
Collaborator

https://github.com/sourcegit-scm/sourcegit/actions/runs/8963157118

  • add Shift+Ctrl+Tab (⌘+⌥+← on macOS) to go to previous page
  • use ESC to cancel commit searching

@successgo
Copy link
Author

Hi @love-linger
As for switching pages Ctrl+Tab and Shift+Ctrl+Tab does not work in v8.11.

@love-linger
Copy link
Collaborator

Hi @love-linger As for switching pages Ctrl+Tab and Shift+Ctrl+Tab does not work in v8.11.

Which OS do you use? On macOS, the hotkey to switch pages is ⌘+⌥+← and ⌘+⌥+→

@love-linger love-linger reopened this May 6, 2024
@successgo
Copy link
Author

It's macOS. I thought you added Ctrl+Tab and Shift+Ctrl+Tab.

@EreMaijala
Copy link
Contributor

@love-linger Ctrl+Tab and Shift+Ctrl+Tab would be nice, but having at least ⌘+⌥+← and ⌘+⌥+→ is nice. :) However, it seems that they clash with other shortcuts and don't work properly if focus is e.g. in the histories graph or "Search Files" field in CHANGES tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants