Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about the repository search filter #117

Closed
gadfly3173 opened this issue May 7, 2024 · 0 comments
Closed

Questions about the repository search filter #117

gadfly3173 opened this issue May 7, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@gadfly3173
Copy link
Contributor

Welcome._searchFilter saves value on each welcome page, however, the Welcome.SetVisibilityBySearch method is used to assign a value to RepositoryNode.IsVisible to control whether to display it. RepositoryNode is loaded through Preference.Instance.RepositoryNodes in Welcome, so RepositoryNode and its display status are in all Shared on the Welcome page. This results in SearchFilter possibly having different values but the same search results in different Welcome pages.
For example, after searching in a Welcome page and then opening a Welcome page, there is input in the search box of the first one but not in the second one, but the second Welcome page still displays the previous search results.

@love-linger love-linger self-assigned this May 7, 2024
@love-linger love-linger added the bug Something isn't working label May 7, 2024
love-linger added a commit that referenced this issue May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants