Fixes and improvements #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `go test -race ./...`, a race condition is reported for a fake implementation of a filesystem for TestCheckAndStore. A mutex lock has been added into the structure functions and test to avoid the error report. Fixes sourcegraph#107
A special checker has been implemented that runs external commands via os.Exec. This opens up the possibility of implementing more complex, protocol-aware checks, without necessarily implementing a custom checker in Go code.
With the upgrade to a recent go version, we're upgrading to use go modules. Makefile was added to provide the proper build commands, test commands and disable cached test output with -count=1.
In order to support building with CGO_ENABLED=0, build tags were added to the sql filesystem implementation. Sqlite requires cgo, and it now needs to be explicitly enabled with `-tags sql` option at build time. Fixes sourcegraph#102
Tcpchecker tests were failing due to expired self signed certificates. This commit adds new certificates, a Makefile for regenerating them, and adds test output in case of similar certificate errors. Fixes sourcegraph#108
|
LGTM |
This was referenced Apr 7, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.