Skip to content

Commit

Permalink
Fix report merging
Browse files Browse the repository at this point in the history
  • Loading branch information
RXminuS committed Oct 21, 2024
1 parent f34d719 commit 6019572
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
11 changes: 6 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -287,18 +287,19 @@ jobs:
name: e2e-html-report
path: vscode/.test/e2e/reports/html
retention-days: 7
- name: Comment on PR
uses: daun/playwright-report-summary@v3
with:
report-file: vscode/.test/e2e/reports/json/report.json
# TODO: Pipe telemetry to PubSub
- name: Report to Services
run: pnpm -C vscode exec playwright merge-reports --reporter github,@estruyf/github-actions-reporter .test/e2e/reports/blob
run: pnpm -C vscode exec playwright merge-reports --reporter github,@estruyf/github-actions-reporter -c .test/e2e/reports/blob .test/e2e/reports/blob
env:
BUILDKITE_ANALYTICS_TOKEN: ${{ secrets.BUILDKITE_ANALYTICS_TOKEN }}
# This is required because the test collector from Buildkite is imprecise when it
# comes to infer the branch name on GitHub action.
BRANCH_NAME: ${{ github.head_ref || github.ref_name }}
GITHUB_REF: ${{ github.head_ref || github.ref_name }}
- name: Comment on PR
uses: daun/playwright-report-summary@v3
with:
report-file: vscode/.test/e2e/reports/json/report.json

# Sets a variable that is used to determine the matrix to run slow tests (e2e) on.
# Everything runs on ubuntu, only commits to main run on macos and windows.
Expand Down
2 changes: 1 addition & 1 deletion vscode/playwright.v2.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ export default defineConfig<WorkerOptions & TestOptions & TmpDirOptions>({
outputDir: '.test/e2e/results',
reporter: isCI
? [
['dot', {}],
['line', { printSteps: false, includeProjectInTestName: false }],
['blob', { outputDir: '.test/e2e/reports/blob' }],
]
: [
Expand Down

0 comments on commit 6019572

Please sign in to comment.