Skip to content

Commit

Permalink
fix(ci): disable google auth login if the PR is from a fork (#5984)
Browse files Browse the repository at this point in the history
Hoping to unblock #5983 and #5982.

In #4923 we added the google
auth action to the test-unit step but did not exclude the step if the PR
comes from a fork (as we do with the other auth steps).

@akalia25 Do you see any issue with this tact? Should the setup-gcloud
step get skipped too?

## Test plan
Runs in CI
  • Loading branch information
jamesmcnamara authored Oct 23, 2024
1 parent dfc9f52 commit 75dc843
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@ jobs:
node-version: ${{ matrix.node }}
- uses: pnpm/action-setup@fe02b34f77f8bc703788d5817da081398fad5dd2 # SECURITY: pin third-party action hashes
- id: auth
uses: google-github-actions/auth@v0
uses: google-github-actions/auth@v2
# Skip auth if PR is from a fork
if: ${{ !github.event.pull_request.head.repo.fork }}
with:
workload_identity_provider: ${{ secrets.DATA_TEAM_PROVIDER_NAME }}
service_account: ${{ secrets.DATA_TEAM_SA_EMAIL }}
Expand Down

0 comments on commit 75dc843

Please sign in to comment.