Cody Ignore: Treat unterminated JSON responses as an outdated API error message #4024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-spiess
approved these changes
May 2, 2024
abeatrix
reviewed
May 2, 2024
| @@ -1029,5 +1029,11 @@ export type LogEventMode = | |||
| | 'all' // log to both dotcom AND the connected instance | |||
|
|
|||
| function hasOutdatedAPIErrorMessages(error: Error): boolean { | |||
| return error.message.includes('Cannot query field') | |||
| // Sourcegraph 5.2.3 returns an empty string ("") instead of an error message | |||
There was a problem hiding this comment.
Would it help to add the getSiteVersion() check to contextFilters?
There was a problem hiding this comment.
Yes, we should fix this properly with something like that.
dominiccooney
added a commit
that referenced
this pull request
May 2, 2024
dominiccooney
added a commit
to sourcegraph/jetbrains
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unbreaks 5.2.3 treating all files as ignored.
Test plan
Tested manually: Log in to 5.2.3 and chat with an @-file mention. You should not get a Cody Ignore error message.