Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webview): Skip webview copying for eclipse #5924

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

jamesmcnamara
Copy link
Contributor

@jamesmcnamara jamesmcnamara commented Oct 16, 2024

In the startup of the agent, we copy over the local webview assets into the cody data directory. This overwrites the template files that eclipse writes to that directory. The eclipse extension is packaged with the webview assets it's compiled with and manages serving those resources from it's own JAR. This change prevents any version mismatch issues that can occur from the double copy.

Also includes a small fix for Java code generation.

Test plan

Manually tested with Eclipse that it resolved issues loading CSS

@jamesmcnamara jamesmcnamara requested a review from a team October 16, 2024 17:28
@jamesmcnamara jamesmcnamara merged commit e630aa8 into main Oct 16, 2024
22 checks passed
@jamesmcnamara jamesmcnamara deleted the jsm/skip-webview-copy branch October 16, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants