E2E: Ensure tests pass on Windows #5942
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 17, 2024
RXminuS
changed the title
RXminuS
force-pushed
the
rnauta/ci-enable-e2e-v2/framework-fixes-1
branch
from
80d03aa
to
cfef0a5
Compare
RXminuS
force-pushed
the
ci-enable-e2e-v2/windows-tweaks-1
branch
from
130799a
to
276e91f
Compare
RXminuS
force-pushed
the
rnauta/ci-enable-e2e-v2/framework-fixes-1
branch
from
cfef0a5
to
8c8d046
Compare
RXminuS
force-pushed
the
ci-enable-e2e-v2/windows-tweaks-1
branch
from
276e91f
to
71004fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we had fairly optimistic timeout & resource usage settings, which on Windows (x86) machines lead to tests frequently timing out.
In addition sub-commands have their stdout inherited which on Windows leads to extremely verbose logging.
Now we tweak the configuration to ensure that tests pass correctly on Windows.
Test plan
E2E tests pass