fix storybook build #5949
Merged
fix storybook build #5949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camdencheek
approved these changes
Oct 18, 2024
jamesmcnamara
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Thanks for fixing this! I did that vite fix here but it hasn't been merged. Up to you if you want to copy it.
beyang
force-pushed
the
bl/fix-storybook
branch
from
bd2d543
to
313f0a9
Compare
|
@jamesmcnamara brilliant, that's exactly the thing I was looking for but wasn't sure how to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change (e9a460e) broke the storybook dev build, because it made
env-pathsa dependency oflib/shared, resulting in an erroros.homedir is not a functionin storybook's browser environment.This fixes it by taking
env-pathsout oflib/shared, duplicating itagent/andvscode/. There may be a more elegant to do this through the vite config—I see a resolve override inagentto prevent this dep from being imported/activated, but not sure how to do that.Test plan
No changes