Remove onKeyPress on AccordionTrigger #5993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thenamankumar
force-pushed
the
naman/onkeypress-noop
branch
from
5f043a1
to
92808f8
Compare
thenamankumar
changed the title
beyang
approved these changes
Oct 24, 2024
beyang
reviewed
Oct 24, 2024
thenamankumar
force-pushed
the
naman/onkeypress-noop
branch
from
3384e9f
to
7019025
Compare
thenamankumar
force-pushed
the
naman/onkeypress-noop
branch
from
7019025
to
74a7ac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: https://sourcegraph.slack.com/archives/C05AGQYD528/p1729773000841009
Somehow
onKeyPresscausing an infinite loop of telemetry records. Also with the most recent changes thecontext items openedevent is getting recorded even when the context menu is closed.This PR makes it so that the event is only getting recorded once.
Test plan
Changelog