Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Polish the enterprise enhanced context selector (#1669)
Fixes #1322, fixes #1425, fixes #1544, fixes #1532, fixes #1542 To summarize the changes: - There are some repo resolution caches to make checking and unchecking faster. - The summary line has been simplified from counting total, ignored, etc. repos to a simple count of repos which will be used (that is, the enabled and not ignored repos, including the automatically included repo if it is not ignored.) - The automatically included repository is represented in the tree view with a "Project repository" label. - There's a separator between the tree view and the rest of the chat panel. There's an expansive tooltip when you hover the separator, but not the tree view so the tooltip does not impede expanding and collapsing the tree view. - The right hand side toolbar is gone, instead, you click on a tree view item to bring up the repo list editor. You can also highlight it with the keyboard and hit "enter". - If you try to enable more than 10 repositories, you get feedback in the form of an error notification. - You can select and deselect repositories and they stay in the repository tree view and are saved in chat state. - The tree view reflects what you wrote in the popup. "Not found" repositories are present with a label. You can delete a repository from the text box to remove it from the tree view. - The contrast and consistency of icons have been improved. - The popup is positioned above the repository list, and is larger. - The intermediate "Repositories" node of the tree view has been removed. Known bugs/caveats: - When selecting/deselecting repositories in the tree view with the keyboard, the item loses focus as the view is reconstructed. - You can add an eleventh repository by specifying 10 repositories that are not the automatically included repository. This one goes up to 11. - Loading a chat with a de-selecting repository that has since been filtered and checking it will result in the "ignored" state appearing. This is because Cody Ignore is applied at late stage of remote repo handling. - Some of the new icons proposed in the design are not incorporated. There are many overlapping versions of the design for this component... I have to draw a line under this and handle any other feedback as follow-ups. - This does not address the https feedback in issue #1322; https URLs are filed in #1354 and will be looked at separately. - Repositories where the entered spec and the resolved name are different may present as duplicates with one "not found." ## Test plan Tested locally ![Screenshot 2024-05-28 at 19 19 09](https://github.com/sourcegraph/jetbrains/assets/55120/1640c6ca-5672-45dc-9f9e-617dfba1966d)
- Loading branch information