Fix formatting for single line completions #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkukielka
force-pushed
the
pkukielka/improve-completion-formatting
branch
from
6f0cc3d
to
4826bcc
Compare
Comment on lines
37
to
46
| TestCase.assertEquals( | ||
| """|public static int fib(int n) { | ||
| | if (n <= 1) { | ||
| | return n; | ||
| | } | ||
| | return fib(n - 1) + fib(n - 2); | ||
| | }""" | ||
| .trimMargin(), | ||
| formatText( | ||
| "public static int fib(int n) { if (n <= 1) { return n; } return fib(n-1) + fib(n-2); }", |
mkondratek
reviewed
Mar 8, 2024
mkondratek
reviewed
Mar 8, 2024
src/main/kotlin/com/sourcegraph/cody/autocomplete/CodyAutocompleteManager.kt
Outdated
Show resolved
Hide resolved
mkondratek
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
The formatting seems to work correctly.
I see a few issues to are probably not related to this PR directly:
fun bubbleSort(array: MutableList<Int>) {in Kotlin does not work (while the similar code in Java produced the proper complection)- multiline suggestions seem to appear very rare
- it's hard to tell that Cody is "thinking" on the autocompletions - we indicator is still broken, we should fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #987
Changes
Fixed formatting (previously non-existing) for single line completions, simplified the code, and added the tests.
Test plan
Automatic tests for formatter were added.
Additionally manual QA was done using
TESTING.MDsectionSingle-line autocomplete' andMulti-line autocomplete`