Fix null issues with URI conversion, add tests #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkukielka
force-pushed
the
pkukielka/fix-url-conversion
branch
2 times, most recently
from
4221318
to
09af87b
Compare
mkondratek
reviewed
Mar 28, 2024
.github/workflows/test.yml
Outdated
| ${{ runner.os }}-gradle- | ||
| - name: Gradle Wrapper Validation | ||
| uses: gradle/wrapper-validation-action@v1.1.0 | ||
| - name: Setup Gradle with caches enabled |
There was a problem hiding this comment.
is gradle/gradle-build-action@v2 with caches enabled by default?
There was a problem hiding this comment.
I couldn't make it to work on windows without bigger build structure refactoring, so I'm backing off from this.
mkondratek
reviewed
Mar 28, 2024
| .serializeNulls() | ||
| .create() | ||
|
|
||
| fun roundtripConversion(path: String) = |
pkukielka
force-pushed
the
pkukielka/fix-url-conversion
branch
10 times, most recently
from
3dedc62
to
bc5ff09
Compare
pkukielka
force-pushed
the
pkukielka/fix-url-conversion
branch
from
bc5ff09
to
b85e29b
Compare
This was referenced Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1202 and similar
Changes
Added additional check in case of
nullcomponents ofURIare received, added tests.Test plan
Automatic tests added