-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix null issues with URI conversion, add tests #1211
Conversation
4221318
to
09af87b
Compare
.github/workflows/test.yml
Outdated
${{ runner.os }}-gradle- | ||
- name: Gradle Wrapper Validation | ||
uses: gradle/wrapper-validation-action@v1.1.0 | ||
- name: Setup Gradle with caches enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is gradle/gradle-build-action@v2
with caches enabled by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't make it to work on windows without bigger build structure refactoring, so I'm backing off from this.
.serializeNulls() | ||
.create() | ||
|
||
fun roundtripConversion(path: String) = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is fine 🚀
3dedc62
to
bc5ff09
Compare
bc5ff09
to
b85e29b
Compare
Fixes #1202 and similar
Changes
Added additional check in case of
null
components ofURI
are received, added tests.Test plan
Automatic tests added