Use the DumbAwareBGTAction interface to silence the update thread warning. #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkukielka
reviewed
Apr 18, 2024
odisseus
force-pushed
the
mg/issue-1327
branch
2 times, most recently
from
6ffeb82
to
d6c9822
Compare
pkukielka
reviewed
Apr 23, 2024
| didUseShortcut(shortcut) | ||
| } | ||
| } | ||
| SimpleDumbAwareBGTAction { didUseShortcut(shortcut) } |
pkukielka
reviewed
Apr 23, 2024
| @@ -124,7 +124,7 @@ class RemoteRepoPopupController(val project: Project) { | |||
| .createPopup() | |||
|
|
|||
| val okAction = | |||
| object : DumbAwareAction() { | |||
| object : DumbAwareBGTAction() { | |||
There was a problem hiding this comment.
SimpleDumbAwareBGTAction? :)
There was a problem hiding this comment.
The SimpleDumbAwareBGTAction doesn't give the lambda access to the action event class. In its current form, it isn't applicable when the event is actually used, though I may consider refactoring it to remove this restriction.
P.S. This action also uses AnAction#unregisterCustomShortcutSet, so the simple wrapper is definitely not applicable here.
pkukielka
reviewed
Apr 23, 2024
| @@ -19,7 +20,7 @@ private constructor(title: String, content: String, shouldShowUpgradeOption: Boo | |||
| init { | |||
| icon = Icons.CodyLogo | |||
| val learnMoreAction: AnAction = | |||
| object : DumbAwareAction("Learn more") { | |||
| object : DumbAwareBGTAction("Learn more") { | |||
There was a problem hiding this comment.
SimpleDumbAwareBGTAction
pkukielka
reviewed
Apr 23, 2024
|
|
||
| if (shouldShowUpgradeOption) { | ||
| val upgradeAction: AnAction = | ||
| object : DumbAwareAction("Upgrade") { | ||
| object : DumbAwareBGTAction("Upgrade") { |
There was a problem hiding this comment.
SimpleDumbAwareBGTAction
pkukielka
reviewed
Apr 23, 2024
| class SimpleDumbAwareBGTAction( | ||
| text: @NlsActions.ActionText String? = null, | ||
| private val action: () -> Unit | ||
| ) : DumbAwareAction(text) { |
There was a problem hiding this comment.
How is that supposed to work? Shouldn't it inherit from DumbAwareBGTAction?
…lence the update thread warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1327.
Test plan
I have clicked around a little bit in IntelliJ IDEA 2024.1.1 RC, and I haven't seen any OLD_EDT warnings in the log.