-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display onboarding tooltip on first autocomplete suggestion #1339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Splendid.
IntelliJ handles the dismissed state management of these? Neat.
@dominiccooney Yes! IntelliJ manages the state. All existing users will get the tooltip when updating, which isn't ideal, but it might be helpful for them to learn about the cycle shortcuts. I think the code will become very tricky to maintain if we try to avoid showing the tooltip for existing users. |
Wouldn't it be nice to also mention command to force autocomplete? |
cc/ @sourcegraph/jetbrains-plugin have you seen this behavior before for autocomplete? The inlay appears in an empty line below the cursor I commented out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #1319. Previously, users didn't get any onboarding instructions when using Cody for the first time in JetBrains. For example, many users didn't know they should press TAB to accept an autocomplete suggestion, or option-bracket to cycle through options. This PR fixes the problem by using the built-in `GotItTooltip` component, which is designed for this use-case.
9443ff4
to
68a0303
Compare
@danielmarquespt merging this PR with the current copy. Feel free to propose a separate copy, or send a PR changing the text. I think we should also document the trigger shortcut in the onboarding tooltip, but it's not done in this PR> |
Fixes #1319.
Previously, users didn't get any onboarding instructions when using Cody for the first time in JetBrains. For example, many users didn't know they should press TAB to accept an autocomplete suggestion, or option-bracket to cycle through options. This PR fixes the problem by using the built-in
GotItTooltip
component, which is designed for this use-case.Test plan
Manually tested.