Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature-tracking: Add a JSON file describing JetBrains status of various features #1400

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

dominiccooney
Copy link
Contributor

This is the JetBrains-side description of the features in sourcegraph/cody#3846

Test plan

This is a data-only change.

Copy link
Contributor

@kalanchan kalanchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gogogo!

@@ -0,0 +1,68 @@
{
"features": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to confirm, we're still sticking with features being an array instead of an object with their keys as the feature name right?

Copy link
Contributor Author

@dominiccooney dominiccooney Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vacillated on this, sent you feedback and then deleted it. You're right, an array is better.

When you're joining the features, it is easier to have the features as an object because you can do lookups easily. But later when we're passing features around, it is easier to have the feature as one object with a name. Otherwise we will be passing [name, featureData] tuples everywhere or always converting Object.entries to a two-prop {name: ..., data: ...} with a lot of useless drilling.

So the array is better. We're just not feeling the benefits yet because we're not really doing much feature handling (my PR over here does one join for merging... sourcegraph/cody#3956 and the array is fine really.)

@dominiccooney dominiccooney merged commit 8a277ff into main Apr 30, 2024
5 checks passed
@dominiccooney dominiccooney deleted the dpc/feature-db branch April 30, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants