Several bug fixes for Inline Edits #1427

steveyegge · 2024-04-30T21:46:56Z

A handful of small but important fixes:

fixed the flicker when resizing the Edit dialog -- looks much nicer now
use the error lens icon from Design, and fixed the error lens icon sizing
cleaned up several memory leaks from listeners left around, including a big exception on exiting the app
fixed an EDT issue with disposing inlays, another runtime exception

Test plan

There were no user-visible changes except for the error icon, which I inspected manually. All unit tests and checks passed.

fixes a big exception on app shutdown

added a 16ms (60fps) debounce, made it nice and smooth

steveyegge added 5 commits April 30, 2024 10:50

Switched error lens icon to the official one

c338e8d

more work on cleanup/disposal

e05bea8

fixes a big exception on app shutdown

fixed error lens icon

31c28d5

fixed flicker when resizing

ad6b6f2

added a 16ms (60fps) debounce, made it nice and smooth

fixed an EDT issue

ae87a56

steveyegge enabled auto-merge (squash) April 30, 2024 21:47

steveyegge requested a review from dominiccooney April 30, 2024 21:47

abeatrix approved these changes Apr 30, 2024

View reviewed changes

steveyegge merged commit 5057216 into main Apr 30, 2024
7 checks passed

steveyegge deleted the stevey/edit-bug-fixes branch April 30, 2024 21:51

steveyegge removed the request for review from dominiccooney April 30, 2024 22:24