Elaborate on documentation for JetBrains releases #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkukielka
reviewed
May 6, 2024
| graph TD; | ||
| Title["JetBrains plugin release"] --> stable; | ||
| Title --> nightly; | ||
| stable --> push_stable["push git tag"]; |
There was a problem hiding this comment.
Today we are using ./scripts/push-git-tag-for-next-release.sh for that (it have some safeguards and also suggests you proper release branch name):
➜ jetbrains git:(pkukielka/move-session-lifecyccle-management-to-agent) ✗ ./scripts/push-git-tag-for-next-release.sh --patch
++ git symbolic-ref --short HEAD
+ CURRENT_BRANCH=pkukielka/move-session-lifecyccle-management-to-agent
+ '[' pkukielka/move-session-lifecyccle-management-to-agent '!=' main ']'
+ echo 'Warning: You are not on the '\''main'\'' branch. You are on '\''pkukielka/move-session-lifecyccle-management-to-agent'\''.'
Warning: You are not on the 'main' branch. You are on 'pkukielka/move-session-lifecyccle-management-to-agent'.
+ read -p 'Are you sure you want to proceed? (y/n): ' proceed
Are you sure you want to proceed? (y/n):
There was a problem hiding this comment.
This is mentioned in the "push a git tag" section below the diagram.
There was a problem hiding this comment.
Ah, it was not expanded in the diff and I missed it, thanks!
steveyegge
pushed a commit
that referenced
this pull request
May 9, 2024
## Test plan Only changing docs. <!-- All pull requests REQUIRE a test plan: https://sourcegraph.com/docs/dev/background-information/testing_principles Why does it matter? These test plans are there to demonstrate that are following industry standards which are important or critical for our customers. They might be read by customers or an auditor. There are meant be simple and easy to read. Simply explain what you did to ensure your changes are correct! Here are a non exhaustive list of test plan examples to help you: - Making changes on a given feature or component: - "Covered by existing tests" or "CI" for the shortest possible plan if there is zero ambiguity - "Added new tests" - "Manually tested" (if non trivial, share some output, logs, or screenshot) - Updating docs: - "previewed locally" - share a screenshot if you want to be thorough - Updating deps, that would typically fail immediately in CI if incorrect - "CI" - "locally tested" -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan
Only changing docs.