-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish the enterprise enhanced context panel #1479
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried it on macOs. Things work ok according to your Test Plan.
I noticed this.
- Hover on "Chat Context X Repos"
- "About chat context" tooltip appears
- Hover on a repository
- Both "About chat context" and repository url (or info about included repo)
Is it ok that we present these two tooltips at once?
messages-panel.welcome-text=Hello! I'm Cody. I can write code and answer questions for you. See [Cody documentation](https://sourcegraph.com/docs/cody) for help and tips. | ||
EndOfTrialNotification.link-action-name=Setup Payment Info | ||
EndOfTrialNotification.do-not-show-again=Don't show again | ||
TrialEndingSoonNotification.ignore=cody.ignore.notification.trial-ending-soon | ||
TrialEndingSoonNotification.ending-soon.title=Your Cody Pro trial is ending soon | ||
TrialEndingSoonNotification.ending-soon.content=Setup your payment information to continue using Cody Pro, you won't be charged until February 21. | ||
TrialEndingSoonNotification.ending-soon.content=Set up your payment information to continue using Cody Pro, you won't be charged until February 21. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not for this PR but we may be able to get rid of TrialEndingSoonNotification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it on windows too - works 🚀
@mkondratek yeah that's not ideal... @danielmarquespt wanted the tooltip to just trigger for the top row, actually. But that will take some work because the tree view items' tooltips are only text. Another problem with this is the positioning gets in the way of the treeview expand/collapse disclosure arrow. @toolmantim is working on a refresh of this UI, so this may not live long. If it is still an issue after the refresh I'll work on custom triggering. It is cheesy but maybe we can watch the mouse movement and push the tooltip in and out of the tooltip properties when the mouse is in the "hot zone" on the top row. Needs investigation whether that will hide the tooltip once it is visible. |
Changes to the enterprise enhanced context panel:
Part of #1322
Test plan
Tested manually.
CODY_JETBRAINS_FEATURES=cody.feature.internals-menu=true
Verify the details of adding repositories with the pencil:
Open the pencil popup, verify that cmd-tab/alt-tab away from IntelliJ and back does not close the popup