Implement textDocument/openDocument #1704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkukielka
force-pushed
the
pkukielka/implement-didOpenDocument
branch
from
ef98ff6
to
c09e4f3
Compare
olafurpg
reviewed
May 31, 2024
| if (onOpenUntitledDocument == null) { | ||
| return CompletableFuture.failedFuture( | ||
| new Exception("No callback registered for textDocument/openUntitledDocument")); | ||
| @JsonRequest("textDocument/openDocument") |
There was a problem hiding this comment.
Note: I think we need clearer names to distinguish
- textDocument/open
- textDocument/openDocument
We can do this separately after GA.
|
@pkukielka , I'm unsure what the state of this is... could you rebase this, take a look at @olafurpg 's feedback, and we'll take a look at it? Nit: spelling in the test plan, outsisde |
|
Replaced by #1903 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Implement handing of the
openDocumentagent call.Test plan
Also