Several fixes for Hotkey Inlay Hints #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- there is a new Preferences option for disabling it
- the hint no longer draws if the selection is only on one line
- this takes care of many annoying cases, such as Find/Replace lighting it up everywhere
- the hint now always draws below the last line of the selection.
- this makes it less intrusive, IMO, as it's out of the way of the cursor
- it's more intuitive, I think -- several users claim that it "used to work that way".
It never actually worked that way; it always drew at the end of the last line of
the selection. But now it does work that way.
- coincidentally and usefully, this also fixes CODY-2541
- getting the hint inlay out of the way of the cursor removed the interference
fixes: CODY-2541
pkukielka
reviewed
Jul 9, 2024
| @@ -41,17 +41,22 @@ class CodySelectionInlayManager(val project: Project) { | |||
| val startOffset = event.newRange.startOffset | |||
| val endOffset = event.newRange.endOffset | |||
| if (startOffset == endOffset) { | |||
| // Don't show if there's no selection. | |||
| return | |||
| return // Don't show if there's no selection. | |||
There was a problem hiding this comment.
@steveyegge Shouldn't isCodyUIHintsEnabled be also checked somewhere in this code block?
I fail to see any place where it is actually used, but perhaps I miss something obvious
There was a problem hiding this comment.
Damn, good catch. I had it at one point, and a merge killed it. Fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on user feedback from GTM and Product, discussions with @danielmarquespt , and my own testing, I've made the following round of fixes to the hotkey hint feature, which shows an inlay with "Ctrl + Alt + ↵ to Edit" at the end of your selections in the editor window:
This makes it less intrusive, IMO, as it's out of the way of the cursor.
I think it's also more intuitive. Several users claim that it "used to work that way". It never actually worked that way; it always drew at the end of the last line of the selection. But now it does work that way.
The one downside is that the hint can sometimes draw rather far from the selection, appearing to be two lines below. We will see how people respond to it.
Coincidentally and usefully, this change also fixes CODY-2541. Getting the hint inlay out of the way of the cursor removed the interference with fine-tuning the selection.
These changes also appear have to fixed CODY-2748, because I reported it and I can no longer reproduce it. It used to be 100% reproducible, so I'm going to mark it closed until it resurfaces.
fixes CODY-2541
fixes CODY-2748
Test plan
This requires UI testing to verify with actual integration tests.
I reviewed the test plan, and these changes do not affect the plan.