Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check editor.isDisposed within com.sourcegraph.cody.autocomplete.CodyAutocompleteManager.displayAgentAutocomplete (fixes #1731) #1914

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Check editor.isDisposed within com.sourcegraph.cody.autocomplete.CodyAutocompleteManager.displayAgentAutocomplete (fixes #1731) #1914

merged 1 commit into from
Jul 17, 2024

Conversation

mkondratek
Copy link
Contributor

@mkondratek mkondratek commented Jul 17, 2024 •
edited
Loading

fixes #1731

Test plan

  1. specific repro steps are unknown but based on the code the error was possible

@mkondratek
Check editor.isDisposed within `com.sourcegraph.cody.autocomplete.C…
b9a06c4 
…odyAutocompleteManager.displayAgentAutocomplete` (fixes #1731)
@mkondratek mkondratek self-assigned this Jul 17, 2024
@mkondratek mkondratek enabled auto-merge (squash) July 17, 2024 11:14
pkukielka
pkukielka approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@pkukielka pkukielka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkondratek mkondratek merged commit cfbfdb1 into main Jul 17, 2024
13 checks passed
@mkondratek mkondratek deleted the mkondratek/fix/1731 branch July 17, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkukielka pkukielka pkukielka approved these changes

Assignees

@mkondratek mkondratek

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mkondratek @pkukielka