Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use ActionGroup.getChildren because it has been marked with @ApiStatus.OverrideOnly #1954

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Do not use ActionGroup.getChildren because it has been marked with @ApiStatus.OverrideOnly #1954

merged 1 commit into from
Jul 26, 2024

Conversation

odisseus
Copy link
Contributor

Fixes #1948.

Test plan

  1. Run ./gradlew runIde.
  2. Open "Preferences → Keymap".
  3. Find a list item named "Cody: AI Coding Assistant with Autocomplete & Chat". Check that it is a dropdown with nested items.
  4. Check that all those nested items are themselves dropdowns which have individual actions nested inside.
Screenshot 2024-07-26 at 11 10 30

@odisseus odisseus requested a review from pkukielka July 26, 2024 09:10
@odisseus odisseus self-assigned this Jul 26, 2024
@odisseus odisseus enabled auto-merge (squash) July 26, 2024 09:11
pkukielka
pkukielka approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@pkukielka pkukielka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odisseus odisseus merged commit cea789e into main Jul 26, 2024
6 of 7 checks passed
@odisseus odisseus deleted the mg/issue-1948 branch July 26, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkukielka pkukielka pkukielka approved these changes

Assignees

@odisseus odisseus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compatibility issue with IntelliJ 2024.1.4
2 participants
@odisseus @pkukielka