Disable highlight pass on mock files #1998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RXminuS
approved these changes
Aug 7, 2024
pkukielka
deleted the
pkukielka/disable-highlight-pass-on-non-code-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Replaces #1995
Fixes Fixes CODY-3166 / #1991
Mock files are used for in-memory buffers. Normally all editable code files are not mocks/in-memory files (even scratches are normal files) so we can assume if file is mock it is most likely some special component for which we do not want to add cody error highlighting.
Test plan
Manually verified that HighlightPass no longer applies to the Repo Editor