Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cody Fix: Properly Handle Edit & Retry #2013

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

RXminuS
Copy link
Contributor

@RXminuS RXminuS commented Aug 8, 2024

We weren't correctly tracking the edit action resulting in that the "Edit & Retry" lens did not work the same way as in VSCode.

Now we add the Edit Action to the global EditorActions and all lenses work correctly.

This change is manly to provide feature parity between JB and VSCode, the feature will probably be disabled by sourcegraph/cody#5143

Fixes #2006
Fixes CODY-3192

Test plan

CI
Manually verified the edit prompt is now shown

Copy link
Contributor Author

RXminuS commented Aug 8, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @RXminuS and the rest of your teammates on Graphite Graphite

Copy link
Contributor

@pkukielka pkukielka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RXminuS RXminuS changed the title Handle edit result Cody Fix: Properly Handle Edit & Retry Aug 8, 2024
@RXminuS RXminuS requested a review from pkukielka August 8, 2024 13:29
@RXminuS RXminuS marked this pull request as ready for review August 8, 2024 13:29
@pkukielka pkukielka merged commit 43f6084 into main Aug 8, 2024
18 of 20 checks passed
@pkukielka pkukielka deleted the rnauta/cody-3192-edit-retry-cody-fix branch August 8, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JetBrains: "Edit & Retry" button is not clickable after performing "Ask Cody to Fix"
2 participants