-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to IntelliJ Platform Gradle Plugin 2 #2194
Conversation
.intellijPlatform/localPlatformArtifacts/bundledPlugin-Git4Idea-2023.2+2.xml
Outdated
Show resolved
Hide resolved
efb7de2
to
e167a9e
Compare
@@ -1,6 +1,6 @@ | |||
distributionBase=GRADLE_USER_HOME | |||
distributionPath=wrapper/dists | |||
distributionUrl=https\://services.gradle.org/distributions/gradle-8.8-bin.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8.10.1 is available but it causes some troubles. Let's stick with 8.10 for now (and wait for 8.10.2).
sinceBuild = properties("pluginSinceBuild") | ||
untilBuild = properties("pluginUntilBuild") | ||
} | ||
val customRunIde by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need separate task?
If we can set version on runIde
then we can do the same, just with fallback to platformVersion
if platformRuntimeVersion
is not available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sadly, it does not work yet
4362fdc
to
a048408
Compare
Locally I see this error for some tests. |
26cfbd9
to
5d77cae
Compare
5d77cae
to
ecc5ce6
Compare
.filter(String::isNotEmpty)) | ||
instrumentationTools() | ||
pluginVerifier() | ||
testFramework(TestFrameworkType.Platform) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes https://github.com/sourcegraph/cody-issues/issues/240
Fixes https://linear.app/sourcegraph/issue/CODY-3713/upgrade-to-intellij-gradle-2x-plugin-to-debug-in-splitmode
Test plan