Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shortcuts for Edit Code on Windows #2223

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Fix shortcuts for Edit Code on Windows #2223

merged 2 commits into from
Sep 5, 2024

Conversation

pkukielka
Copy link
Contributor

Changes

Removes annoying Alt + Enter shortcut and unifies both bringing Edit Code prompt and confirming an edit into a single shortcut.

Test plan

  1. Select some code in the editor
  2. Hit Ctrl Enter to show Edit Code prompt
  3. Add some instruction, e.g. to add comments
  4. Hit Ctrl Enter again to confirm the changes and do an edit

dominiccooney
dominiccooney approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@dominiccooney dominiccooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkukielka pkukielka merged commit 78b09c1 into main Sep 5, 2024
6 of 7 checks passed
@pkukielka pkukielka deleted the pkukielka/fix-windows-shortcuts branch September 5, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiccooney dominiccooney dominiccooney approved these changes

@mkondratek mkondratek mkondratek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pkukielka @dominiccooney @mkondratek