Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register widgets for disposal #2225

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Register widgets for disposal #2225

merged 1 commit into from
Sep 5, 2024

Conversation

mkondratek
Copy link
Contributor

@mkondratek mkondratek commented Sep 5, 2024

Test plan

  1. n/a

val isNewTask = !lensGroups.containsKey(taskId)
lensGroup.show(range, shouldScrollToLens = isNewTask)
}
val vf = CodyEditorUtil.findFileOrScratch(project, uri) ?: return
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only removed runInEdt {} wrapping here as we do it where we call the method

@mkondratek mkondratek changed the title Fixes Register widgets for disposal Sep 5, 2024
Copy link
Contributor

@pkukielka pkukielka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkondratek mkondratek merged commit 1406a49 into main Sep 5, 2024
12 of 13 checks passed
@mkondratek mkondratek deleted the mkondratek/minor-fixes branch September 5, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants