Fix chat history download #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkondratek
reviewed
Sep 12, 2024
Comment on lines
+166
to
+183
| browser.jbCefClient.addDownloadHandler( | ||
| object : CefDownloadHandler { | ||
| override fun onBeforeDownload( | ||
| browser: CefBrowser?, | ||
| downloadItem: CefDownloadItem?, | ||
| suggestedName: String?, | ||
| callback: CefBeforeDownloadCallback? | ||
| ) { | ||
| callback?.Continue(/* downloadPath = */ "", /* showDialog = */ true) | ||
| } | ||
|
|
||
| override fun onDownloadUpdated( | ||
| browser: CefBrowser?, | ||
| downloadItem: CefDownloadItem?, | ||
| callback: CefDownloadItemCallback? | ||
| ) {} | ||
| }, | ||
| browser.cefBrowser) |
There was a problem hiding this comment.
Yep ^^ Also no Cody changes needed.
abeatrix
approved these changes
Sep 12, 2024
mkondratek
added a commit
to sourcegraph/cody
that referenced
this pull request
Sep 12, 2024
~Let's include the change from the release branch (#5405 Fixed in JB: sourcegraph/jetbrains#2282 ## Test plan - chat export works <!-- Required. See https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles. --> ## Changelog <!-- OPTIONAL; info at https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c -->
pkukielka
added a commit
that referenced
this pull request
Sep 19, 2024
Fixes #2274 ## Test plan 1. Open Cody chat history 2. Click "Export History" 3. Select a file and path of your choice to save it 4. Verify that file content contains proper json
pkukielka
added a commit
that referenced
this pull request
Sep 19, 2024
Fixes #2274 ## Test plan 1. Open Cody chat history 2. Click "Export History" 3. Select a file and path of your choice to save it 4. Verify that file content contains proper json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2274
Test plan