-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix chat history download #2282
Conversation
browser.jbCefClient.addDownloadHandler( | ||
object : CefDownloadHandler { | ||
override fun onBeforeDownload( | ||
browser: CefBrowser?, | ||
downloadItem: CefDownloadItem?, | ||
suggestedName: String?, | ||
callback: CefBeforeDownloadCallback? | ||
) { | ||
callback?.Continue(/* downloadPath = */ "", /* showDialog = */ true) | ||
} | ||
|
||
override fun onDownloadUpdated( | ||
browser: CefBrowser?, | ||
downloadItem: CefDownloadItem?, | ||
callback: CefDownloadItemCallback? | ||
) {} | ||
}, | ||
browser.cefBrowser) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is that all? 😮
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep ^^ Also no Cody changes needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are a wizards 🧙!
~Let's include the change from the release branch (#5405 Fixed in JB: sourcegraph/jetbrains#2282 ## Test plan - chat export works <!-- Required. See https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles. --> ## Changelog <!-- OPTIONAL; info at https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c -->
Fixes #2274 ## Test plan 1. Open Cody chat history 2. Click "Export History" 3. Select a file and path of your choice to save it 4. Verify that file content contains proper json
Fixes #2274 ## Test plan 1. Open Cody chat history 2. Click "Export History" 3. Select a file and path of your choice to save it 4. Verify that file content contains proper json
Fixes #2274
Test plan