Add CodyInlineCompletionProvider as an alternative for inlay completions #2304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkukielka
pushed a commit
that referenced
this pull request
Sep 16, 2024
A prerequisite for #2304. ## Test plan 1. Verify Settings UI
mkondratek
commented
Sep 16, 2024
src/main/kotlin/com/sourcegraph/cody/autocomplete/CodyInlineCompletionProvider.kt
Outdated
Show resolved
Hide resolved
mkondratek
force-pushed
the
mkondratek/feat/completion-provider
branch
from
fae67b6
to
24c90e1
Compare
mkondratek
changed the title
mkondratek
force-pushed
the
mkondratek/feat/completion-provider
branch
2 times, most recently
from
7ece535
to
a465643
Compare
Closed
mkondratek
force-pushed
the
mkondratek/feat/completion-provider
branch
2 times, most recently
from
8d81671
to
e4042a0
Compare
mkondratek
force-pushed
the
mkondratek/feat/completion-provider
branch
from
e4042a0
to
587af90
Compare
pkukielka
reviewed
Oct 4, 2024
| @@ -580,19 +590,6 @@ tasks { | |||
|
|
|||
| test { dependsOn(project.tasks.getByPath("buildCody")) } | |||
|
|
|||
| configurations { | |||
There was a problem hiding this comment.
It looks so. the test are passing without it. Note that configuration creation is redundant. SourceSets persist.
pkukielka
reviewed
Oct 4, 2024
build.gradle.kts
Outdated
| @@ -499,6 +507,8 @@ tasks { | |||
|
|
|||
| buildPlugin { | |||
| dependsOn(project.tasks.getByPath("buildCody")) | |||
| val get = composedJar.get() | |||
There was a problem hiding this comment.
get does not sound like nice name ^^
Maybe just inline it?
pkukielka
reviewed
Oct 4, 2024
| @@ -25,6 +25,7 @@ class CodyDocumentListener(val project: Project) : BulkAwareDocumentListener { | |||
| } | |||
| } | |||
|
|
|||
| // todo: documentChanged | |||
There was a problem hiding this comment.
Remove or make it more meaningful please.
pkukielka
approved these changes
Oct 4, 2024
mkondratek
force-pushed
the
mkondratek/feat/completion-provider
branch
from
070ff95
to
3798bdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://linear.app/sourcegraph/issue/CODY-3742.
Based on PR #2303
Full chain of PRs as of 2024-09-16
mkondratek/feat/completion-provider➔mkondratek/chore/ui-fixeshorizontalAlign#2303:mkondratek/chore/ui-fixes➔mainTest plan
AUTOMATIC
Expected: autocompletion suggested
INVOKE
shift + option + \on macOSExpected: autocompletion suggested