-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CodyInlineCompletionProvider as an alternative for inlay completions #2304
Conversation
A prerequisite for #2304. ## Test plan 1. Verify Settings UI
src/main/kotlin/com/sourcegraph/cody/autocomplete/CodyInlineCompletionProvider.kt
Outdated
Show resolved
Hide resolved
fae67b6
to
24c90e1
Compare
7ece535
to
a465643
Compare
8d81671
to
e4042a0
Compare
e4042a0
to
587af90
Compare
@@ -580,19 +590,6 @@ tasks { | |||
|
|||
test { dependsOn(project.tasks.getByPath("buildCody")) } | |||
|
|||
configurations { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was that not needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks so. the test are passing without it. Note that configuration creation is redundant. SourceSets persist.
build.gradle.kts
Outdated
@@ -499,6 +507,8 @@ tasks { | |||
|
|||
buildPlugin { | |||
dependsOn(project.tasks.getByPath("buildCody")) | |||
val get = composedJar.get() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get
does not sound like nice name ^^
Maybe just inline it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -25,6 +25,7 @@ class CodyDocumentListener(val project: Project) : BulkAwareDocumentListener { | |||
} | |||
} | |||
|
|||
// todo: documentChanged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove or make it more meaningful please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left few comments, otherwise LGTM
070ff95
to
3798bdc
Compare
Fixes https://linear.app/sourcegraph/issue/CODY-3742.
Based on PR #2303
Full chain of PRs as of 2024-09-16
mkondratek/feat/completion-provider
➔mkondratek/chore/ui-fixes
horizontalAlign
#2303:mkondratek/chore/ui-fixes
➔main
Test plan
AUTOMATIC
Expected: autocompletion suggested
INVOKE
shift + option + \
on macOSExpected: autocompletion suggested