Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a compile error caused by a simple name change #2313

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

steveyegge
Copy link
Contributor

Agent-side changed one of the message names; no other changes were needed

Test plan

Locally tested.

Agent-side changed one of the message names; no other changes were needed
@steveyegge steveyegge self-assigned this Sep 17, 2024
@steveyegge steveyegge requested review from mkondratek, dominiccooney and abeatrix and removed request for mkondratek September 17, 2024 21:22
@steveyegge steveyegge enabled auto-merge (squash) September 17, 2024 21:22
Copy link
Contributor

@dominiccooney dominiccooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears broken in CI, you might need to roll the Cody agent version at the same time...

@dominiccooney
Copy link
Contributor

I am rolling the Cody commit to pull in the upstream change this fix depends on.

Copy link
Contributor

@dominiccooney dominiccooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once we roll the Cody commit.

@steveyegge steveyegge closed this Sep 18, 2024
@steveyegge steveyegge reopened this Sep 18, 2024
@steveyegge steveyegge enabled auto-merge (squash) September 18, 2024 20:50
@steveyegge steveyegge merged commit 53144a6 into main Sep 18, 2024
10 of 11 checks passed
@steveyegge steveyegge deleted the stevey/fix-webnativeconfig-compile-error branch September 18, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants