Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify build properties #2370

Conversation

dominiccooney
Copy link
Contributor

@dominiccooney dominiccooney commented Oct 2, 2024

  • Remove redundant forceCodyBuild variable, use forceAgentBuild
  • Remove undocumented forceBuild variable

Test plan

./gradlew buildPlugin -PforceAgentBuild=true
./gradlew buildPlugin -PforceAgentBuild=true

and verify that the Cody step, pnpm run -s build:root && pnpm run -s build:webviews && pnpm run -s build:agent, runs both times.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dominiccooney and the rest of your teammates on Graphite Graphite

@dominiccooney dominiccooney changed the title Remove redundant forceCodyBuild variable, remove undocumented forceBuild variable. Simplify build properties Oct 2, 2024
@dominiccooney dominiccooney requested a review from a team October 2, 2024 06:11
@dominiccooney dominiccooney marked this pull request as ready for review October 2, 2024 06:11
@dominiccooney dominiccooney force-pushed the 10-02-remove_redundant_forcecodybuild_variable_remove_undocumented_forcebuild_variable branch from 1003854 to e5a2605 Compare October 2, 2024 06:33
Copy link
Contributor

@pkukielka pkukielka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dominiccooney dominiccooney merged commit 18be103 into main Oct 2, 2024
7 of 8 checks passed
Copy link
Contributor Author

Merge activity

@dominiccooney dominiccooney deleted the 10-02-remove_redundant_forcecodybuild_variable_remove_undocumented_forcebuild_variable branch October 2, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants