Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dep on m.intellij.modules.lang #2372

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

mkondratek
Copy link
Contributor

@mkondratek mkondratek commented Oct 2, 2024

Fixes https://linear.app/sourcegraph/issue/CODY-3895/drop-dependency-on-comintellijmoduleslang-to-support-gateway.

I removed this dep. I tried our features. I see no problems. Verifier does not complain about it missing. I seems that the dependence is redundant.

Test plan

  1. Full QA, try autocomplete

@mkondratek mkondratek self-assigned this Oct 2, 2024
Copy link
Contributor

@pkukielka pkukielka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkondratek mkondratek merged commit 5d264f8 into main Oct 2, 2024
9 checks passed
@mkondratek mkondratek deleted the mkondratek/chore/remove-redundant-dep branch October 2, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants