Update codyCommit #308
Merged
Update codyCommit #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkondratek
commented
Jan 16, 2024
| data class ContextFile( | ||
| val fileName: String, | ||
| val uri: URI, |
mkondratek
commented
Jan 16, 2024
| val repoName: String?, | ||
| val revision: String?, | ||
| ) | ||
|
|
||
| val contextFileDeserializer = |
There was a problem hiding this comment.
For some reason, deserialization did not work out of the box.
There was a problem hiding this comment.
IMO, we shouldn't do that in this way. Are these deserialization issues caused by the String->URI change or something else has been changed/introduced?
exigow
reviewed
Jan 16, 2024
| data class ContextFile( | ||
| val fileName: String, | ||
| val uri: URI, | ||
| val repoName: String?, | ||
| val revision: String?, | ||
| ) |
There was a problem hiding this comment.
We should test this String->URI change on Windows. Recently, there were issues because the agent has a URI in a different RFC than those built-in in Java.
Base automatically changed from
pkukielka/reimplement-agent-lifecycle-management
to
main
January 17, 2024 09:23
mkondratek
force-pushed
the
mkondratek/update-cody-commit-2024-01-16
branch
from
cbb38bb
to
e17daff
Compare
pkukielka
force-pushed
the
mkondratek/update-cody-commit-2024-01-16
branch
from
cf6437c
to
1ab2e46
Compare
mkondratek
force-pushed
the
mkondratek/update-cody-commit-2024-01-16
branch
from
5d4c3a8
to
5529006
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan