-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update codyCommit #308
Update codyCommit #308
Conversation
data class ContextFile( | ||
val fileName: String, | ||
val uri: URI, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
val repoName: String?, | ||
val revision: String?, | ||
) | ||
|
||
val contextFileDeserializer = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, deserialization did not work out of the box.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, we shouldn't do that in this way. Are these deserialization issues caused by the String->URI change or something else has been changed/introduced?
data class ContextFile( | ||
val fileName: String, | ||
val uri: URI, | ||
val repoName: String?, | ||
val revision: String?, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should test this String->URI change on Windows. Recently, there were issues because the agent has a URI in a different RFC than those built-in in Java.
cbb38bb
to
e17daff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cf6437c
to
1ab2e46
Compare
5d4c3a8
to
5529006
Compare
Test plan