Fix Sourcegraph actions (search selection, open selection, etc) #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkondratek
commented
Jan 22, 2024
| @@ -156,7 +156,7 @@ class CodyToolWindowContent(private val project: Project) : UpdatableChat { | |||
| SUBSCRIPTION_TAB_INDEX) | |||
| } | |||
| subscriptionPanel.update(data.isCurrentUserPro) | |||
| } else { | |||
| } else if (SUBSCRIPTION_TAB_INDEX < tabbedPane.tabCount) { | |||
There was a problem hiding this comment.
unrel to the sourcegraph actions issue - minor fix (IndexOutOfBoundsException appeared once from this place)
mkondratek
commented
Jan 22, 2024
Comment on lines
+156
to
+164
| if (ConfigUtil.isCodyEnabled()) { | ||
| codebaseName = | ||
| CodyAgentService.getAgent(project) | ||
| .thenCompose( | ||
| agent -> | ||
| agent.getServer().convertGitCloneURLToCodebaseName(new CloneURL(cloneURL))) | ||
| .completeOnTimeout(/* value= */ null, /* timeout= */ 4, TimeUnit.SECONDS) | ||
| .get(); | ||
| } |
There was a problem hiding this comment.
Let's try to use agent only with Cody enabled. Also let's complete on timeout.
mkondratek
commented
Jan 22, 2024
| "Failed to convert git clone URL to codebase name for cloneURL: " + cloneURL); | ||
| logger.warn( | ||
| "Failed to convert git clone URL to codebase name for cloneURL via agent: " + cloneURL); | ||
| codebaseName = convertGitCloneURLToCodebaseNameOrError(cloneURL); |
There was a problem hiding this comment.
This is a fallback...
mkondratek
commented
Jan 22, 2024
|
|
||
| import java.net.URL | ||
|
|
||
| fun convertGitCloneURLToCodebaseNameOrError(cloneURL: String): String { |
There was a problem hiding this comment.
copied from the agent and translated (TS -> Kotlin)
mkondratek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #252.
Fixes #162.
Fixes #324.
Test plan