Add support for local symf context #326
Conversation
pkukielka
changed the title
pkukielka
force-pushed
the
pkukielka/add-support-for-symf
branch
from
19ab007
to
3ef379b
Compare
| ApplicationManager.getApplication().executeOnPooledThread { refreshSubscriptionTab() } | ||
|
|
||
| ApplicationManager.getApplication().executeOnPooledThread { |
There was a problem hiding this comment.
any reason to run it on a separate pooled thread than refreshSubscriptionTab() above?
There was a problem hiding this comment.
Yes thank you! This is a merge error. It was supposed to be invokeLater!
There was a problem hiding this comment.
Actually I removed it altogether, it is not needed anymore after I discussed some design changes with Olaf.
src/main/kotlin/com/sourcegraph/cody/context/ui/ContextRepositoriesCheckboxRenderer.kt
Show resolved
Hide resolved
| when (val userObject = value.userObject) { | ||
| is Project -> { | ||
| textRenderer.appendHTML( | ||
| "<b>${userObject.name}</b> - <i>${userObject.basePath}</i>", |
There was a problem hiding this comment.
- we will need to verify it on the latest supported version of the IDE
There was a problem hiding this comment.
Looks fine on 2023.1.1, 2023.2.2 and 2023.3.2.
2022.1 is fine as well.
| tab.subscription.already-pro=(Already upgraded to Pro? Restart your IDE for changes to take effect) | ||
| context-panel.panel-name="Chat Context" | ||
| context-panel.reindex-button-name=""Trigger Reindexing"" | ||
| context-panel.in-progress="Running Cody 'Keyword Search' indexer..." |
There was a problem hiding this comment.
- pls double check the rendering of
'- sometimes it is needed to write''to see a single'
There was a problem hiding this comment.
Already fixed, thanks.
src/main/kotlin/com/sourcegraph/cody/context/ui/EnhancedContextPanel.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Can you please share some ideas for repo-specific questions? I'm trying to ask for smth like 'show me the class where service X is used' or 'list the classes that are written in Kotlin' or 'show me usages of X', but I'm missing something.
Also: I think that we should update testing guide with this feature ("Ask repo-specific question with local-only context").
pkukielka
force-pushed
the
pkukielka/add-support-for-symf
branch
from
7191a22
to
042f496
Compare
There was a problem hiding this comment.
From our private conversation, it emerged that to properly test, we must ask a precise question like "what is the first line of the CodyEditorFactoryListener class?". I was able to correctly test this feature with this tip.
However, I have two small topics:
- We should bump the version to the Cody commit if this feature requires the latest version. I had to manually bump the version, and it was not obvious to me. It seems to me that developers should not be expected to work on CODY_DIR that is built on the latest main, especially since we often have to go back in history. This causes some conflicts on merge, but this can be simply fixed.
- We should add to
testing.mdinformation that to objectively test this feature, we must specify the question in precise way, e.g., "what is the first line of the CodyEditorFactoryListener class?". This also was not obvious to me.
Looks good! 👍
|
I've spotted some bug: if you click refresh while a response is still being generated, an error |
Fixes #259
Test plan
Manual testing using full QA guide.
Other than that:
Enable context
Ask repo-specific question
Check if response is based on the understanding of the local context
Disable context
Ask repo-specific question
Check if response is lacking previous insight
Click on refresh button and check if reindexing is in progress
Click on help button and check if it opens proper documentation page