Expand context panel tree on EDT #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkukielka
reviewed
Jan 25, 2024
|
|
||
| add(toolbarPanel) | ||
| // Fix for https://github.com/sourcegraph/jetbrains/issues/344 |
There was a problem hiding this comment.
I think that fix is right.
Looks like EnhancedContextPanel is created in ChatPanel constructor and ChatPanel in turn in the CodyToolWindowContent.
CodyToolWindowContent is a IJ project-level service object, and its lifecycle is controlled by IJ.
I found this info in IJ documentation:
Getting a service doesn't need a read action and can be performed from any thread. If a service is requested from several threads, it will be initialised in the first thread, and other threads will be blocked until it is fully initialised.
So you are probably right, it's a race. We need to be on a safe side there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the recent exception I'm seeing in nightly.
I unfortunately was not able to repro with a local build. So I'm not sure how it's getting called from a non-EDT thread -- some sort of race condition, possibly. But this looks like the right fix -- I tried it with/without, and the new context panel expands the tree properly for me in both cases.
Test plan
Manual testing. Passed.