Fix internal error on quick project close & open #447
Conversation
| .orTimeout(4, TimeUnit.SECONDS) | ||
| .getNow(false) == true |
There was a problem hiding this comment.
I've seen the error coming from this place. I managed to get it twice but it's a race (hard to reproduce). This approach will not throw anything.
| .orTimeout(4, TimeUnit.SECONDS) | ||
| .getNow(false) == true |
There was a problem hiding this comment.
Same as above. I did the same thing in other places where it seemed relevant.
| val notify = didStatusChanged(project) | ||
| if (notify) { | ||
| updateCodyStatusBarIcons() | ||
| if (!project.isDisposed) { |
There was a problem hiding this comment.
Another issue - the same scenario (a quick open & close project) - this one is (almost) deterministic. Should not be a case anymore.
| ApplicationManager.getApplication().invokeLater { | ||
| UpgradeToCodyProNotification(title, content, shouldShowUpgradeOption).notify(project) | ||
| } | ||
| UpgradeToCodyProNotification(title, content, shouldShowUpgradeOption).notify(project) |
There was a problem hiding this comment.
Unrel: redundant invokeLater - notify handles the threading already.
| @@ -159,8 +159,8 @@ private static String doReplacements( | |||
| .thenCompose( | |||
| agent -> | |||
| agent.getServer().convertGitCloneURLToCodebaseName(new CloneURL(cloneURL))) | |||
| .completeOnTimeout(/* value= */ null, /* timeout= */ 4, TimeUnit.SECONDS) | |||
| .get(); | |||
| .orTimeout(4, TimeUnit.SECONDS) | |||
There was a problem hiding this comment.
Why that change?
I do not understand how .orTimeout(...).getNow(null) is supposed to work, orTimeout throws exception after a given time, but getNow returns immediately. That orTimeout will do nothing there. I think .completeOnTimeout(...).get() was in fact proper solution.
Please elaborate :)
There was a problem hiding this comment.
Hmmm... I did think about it. Probably getnow. Ignores the timeout 🤔 anyway. My point is I want to ensure that the timeout applies and get will not throw
mkondratek
force-pushed
the
mkondratek/fix/a-few-fixes
branch
from
4e10c98
to
44cc35d
Compare
|
The icon is more visible and has the same colors as everywhere else.
|
mkondratek
force-pushed
the
mkondratek/fix/a-few-fixes
branch
from
44cc35d
to
7f933ea
Compare
…ect close; similar fixes
…ect close; similar fixes - V2
mkondratek
force-pushed
the
mkondratek/fix/a-few-fixes
branch
from
7f933ea
to
894a095
Compare
Test plan