Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EDT violations and chat refresh #460

Merged
merged 5 commits into from
Feb 1, 2024
Merged

Conversation

pkukielka
Copy link
Contributor

Test plan

Full QA before today's release.

@pkukielka pkukielka changed the title Pkukielka/fix edt violations Fix EDT violations and chat refresh Feb 1, 2024
Copy link
Contributor

@Sa1to Sa1to left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mkondratek mkondratek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - quickly tested, no slow ops reported

Comment on lines +24 to +26
if (chatMessages.lastOrNull()?.speaker == Speaker.HUMAN) {
found.setUpdatedTimeAt(LocalDateTime.now())
}
Copy link
Contributor

@mkondratek mkondratek Feb 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the flickering list when +2 responses are being generated.

@@ -75,18 +76,12 @@ class CodyAutocompleteStatusService : CodyAutocompleteStatusListener, Disposable
}

private fun updateCodyStatusBarIcons() {
val action = Runnable {
UIUtil.invokeLaterIfNeeded {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrel fix

Copy link
Contributor

@Sa1to Sa1to left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@exigow exigow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on Windows!

@Sa1to Sa1to merged commit b1f3c6a into main Feb 1, 2024
1 of 2 checks passed
@Sa1to Sa1to deleted the pkukielka/fix-edt-violations branch February 1, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants