-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Remove all accounts" testing steps #473
Conversation
#### Expected behaviour | ||
|
||
* Cody toolbar is automatically refreshed and the user is greeted with the `Welcome to Cody` panel. | ||
* Status bar widget has a `No account signed-in` status. Status bar is located in the bottom right corner of the IDE. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Should we expect anything more here?
We need to describe this scenario explicitly because during the last release, this part was completely missed, and the issue was (fortunately) discovered by accident. ## Testing plan N/A
|
||
#### Expected behaviour | ||
|
||
* Cody toolbar is automatically refreshed and the user is greeted with the `Welcome to Cody` panel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: s/toolbar/tool window/g
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, but what do you mean by s/toolbar/tool window/g
? 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's sed replace syntax, it means you have typo or other text bug which reviewer is asking you to fix ;)
g
means global
, so it replaces all occurences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a liberty to merge it, we can improve it next time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation: We need to describe this scenario explicitly because during the last release, this part was completely missed, and the issue was (fortunately) discovered by accident 1 hour before the release.
Also, I simplified the SSO testing because we had three headers for essentially the same thing.
Test plan
N/A