Add "Remove all accounts" testing steps #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exigow
commented
Feb 2, 2024
| #### Expected behaviour | ||
|
|
||
| * Cody toolbar is automatically refreshed and the user is greeted with the `Welcome to Cody` panel. | ||
| * Status bar widget has a `No account signed-in` status. Status bar is located in the bottom right corner of the IDE. | ||
|
|
There was a problem hiding this comment.
Question: Should we expect anything more here?
We need to describe this scenario explicitly because during the last release, this part was completely missed, and the issue was (fortunately) discovered by accident. ## Testing plan N/A
mkondratek
reviewed
Feb 2, 2024
|
|
||
| #### Expected behaviour | ||
|
|
||
| * Cody toolbar is automatically refreshed and the user is greeted with the `Welcome to Cody` panel. |
There was a problem hiding this comment.
nit: s/toolbar/tool window/g
There was a problem hiding this comment.
Sorry, but what do you mean by s/toolbar/tool window/g? 😄
There was a problem hiding this comment.
It's sed replace syntax, it means you have typo or other text bug which reviewer is asking you to fix ;)
g means global, so it replaces all occurences.
There was a problem hiding this comment.
I took a liberty to merge it, we can improve it next time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: We need to describe this scenario explicitly because during the last release, this part was completely missed, and the issue was (fortunately) discovered by accident 1 hour before the release.
Also, I simplified the SSO testing because we had three headers for essentially the same thing.
Test plan
N/A