-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attribution Chat UI #476
Merged
Merged
Attribution Chat UI #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Cody typing is cancelled
mkondratek
reviewed
Feb 6, 2024
src/main/kotlin/com/sourcegraph/cody/ui/AttributionButtonController.kt
Outdated
Show resolved
Hide resolved
mkondratek
reviewed
Feb 6, 2024
src/main/kotlin/com/sourcegraph/cody/ui/AttributionButtonController.kt
Outdated
Show resolved
Hide resolved
mkondratek
approved these changes
Feb 6, 2024
…long of a tooltip
It looks much better now 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes sourcegraph/sourcegraph#59335
This pull-request implements attribution search in Chat:
attribution/search
(see Agent attribution API cody#2798)Synopsis of main participating classes (in order of appearance):
AttributionSearchCommand
starts attribution search and then notifies UI of the result.AttributionButtonController
drives UI changes of the attribution button.ConditionalVisibilityButton
allows for showing the attribution button on hover (visible
) only if attribution is enabled (visibilityAllowed
)Besides the UI changes to arrange everything neatly are a little scattered around.
User interface
Visually the indicator is a disabled button to match the current copy/paste at cursor buttons. @danielmarquespt is working on design to match the VS Code UI layout.
Check pending
Check passed
Check failed
Test plan
I gave up on trying to write a component or acceptance test here, since we really need to do the heavy lifting of making this extension testable. This work is beyond the scope of this issue and the timelines we have at this point, but I will come back to that (https://github.com/sourcegraph/sourcegraph/issues/60136)