Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate chats between accounts #503

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Isolate chats between accounts #503

merged 1 commit into from
Feb 7, 2024

Conversation

exigow
Copy link
Contributor

@exigow exigow commented Feb 6, 2024

Fixes #374

Test Plan

Prerequisite: You need two working accounts. Preferably one Free, and one Enterprise.

  1. Switch to first account.
  2. Send a message.
  3. Switch to second account.
  4. Send a message.

These two chats should be isolated between different accounts. Both accounts should have one conversation each. It doesn't matter if you're on FREE or Enterprise: every chat now is assigned to account.

You should also be able to switch between accounts while tokens are still being generated.

Note about migration: Old chats will preserved in the new schema. This works so that orphaned chats will be assigned to the currently active account.

@exigow exigow self-assigned this Feb 6, 2024
@exigow
Copy link
Contributor Author

exigow commented Feb 6, 2024

TODO: What if users have serialized chats without an assigned userId? Should they see them on each account, or should be skipped during deser? fixed

@exigow exigow marked this pull request as ready for review February 6, 2024 20:45
Copy link
Contributor

@pkukielka pkukielka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@exigow exigow merged commit 1204f1c into main Feb 7, 2024
2 checks passed
@exigow exigow deleted the exigow/isolate-chats branch February 7, 2024 13:17
Fixes #374

1. Switch to first account.
2. Send a message.
3. Switch to second account.
4. Send a message.

These two chats should be isolated between different accounts. Both accounts should have per one conversation each.

You should also be able to switch accounts while tokens are still being generated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants