Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-repo enterprise context #510

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Conversation

pkukielka
Copy link
Contributor

@pkukielka pkukielka commented Feb 6, 2024

Test plan

  1. Open sourcegraph/cody project with non-enterprise account.
  • Open new chat and ask question about current repo (e.g. some class) - assistant should know the answer
  • Open new chat and ask question about squirrel - assistant should describe you an animal
  • Open new chat and disable local context. Ask about current repo (e.g. some class) - assistant should not have a context
  • Save current context as default. Close the IDE. Reopen the IDE.
    • Go to Chat History tab and open previous chats one by one. Check if both history and context settings are properly preserved.
    • Open new chat and check if context is disabled. It should be, as we previously set that as new default. Enable it again and set as default.
  1. Open sourcegraph/cody project with enterprise account.
  • All checks from point 1) apply there as well.
  • Click [+] button in the context panel and type sourcegraph repo url (github.com/sourcegraph/sourcegraph)
    • Check if validator blocks from entering incomplete or invalid URL
    • Add the sourcegraph/sourcegraph repo by hitting Add button
  • Open new chat and ask question about squirrel - assistant should describe you an HTTP server, NOT animal.
  • Set new configuration as default and open new chat. It should use previous context configuration.
  • Disable sourcegraph/sourcegraph remote repo context.
  • Ask question about squirrel. It should be back to describing you an animal or having no context.
  • Save current context as default. Close the IDE. Reopen the IDE.
    • Go to Chat History tab and open previous chats one by one. Check if both history and context settings are properly preserved.
    • Open new chat and check if sourcegraph/sourcegraph is disabled. It should be, as we previously set that as new default. Enable it again and set as default.
    • Open new chat and check if sourcegraph/sourcegraph is enabled, it should be.
    • Remove sourcegraph/sourcegraph repo by clicking on it to select it, and then clicking [-] button.
    • Ask question about squirrel. It should be back to describing you an animal or having no context.

Changes

  • Added multi-repo enterprise context
  • Improved look of the local context panel
  • Fixed several bugs like:
    • history service being instantiated as application-wide service instead of project-wide
    • current repo url parsing and timing issues

image

@pkukielka pkukielka force-pushed the pkukielka/multi-repo-enterprise branch 2 times, most recently from d737253 to 30a9b9d Compare February 7, 2024 11:15
TESTING.md Outdated Show resolved Hide resolved
exigow

This comment was marked as resolved.

@pkukielka pkukielka force-pushed the pkukielka/multi-repo-enterprise branch from 4a96d86 to 1f62f8c Compare February 7, 2024 14:08
@pkukielka pkukielka merged commit e571c9e into main Feb 7, 2024
2 checks passed
@pkukielka pkukielka deleted the pkukielka/multi-repo-enterprise branch February 7, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants