Hide stable releases by default #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkondratek
commented
Feb 6, 2024
|
|
||
| channels.set( | ||
| listOf( | ||
| properties("pluginVersion").split('-').getOrElse(1) { "default" }.split('.').first())) |
There was a problem hiding this comment.
.split('.').first()
This ☝️ was redundant. Historically, the plugin supported versions like 2.1.7-alpha.3. It's no longer a case for us.
mkondratek
commented
Feb 6, 2024
| // The published version WILL NOT be available right after the JetBrains approval. | ||
| // Instead, we control if and when we want to make it available. | ||
| // (Note: there is ~48h waiting time for JetBrains approval). | ||
| hidden.set(true) |
There was a problem hiding this comment.
mkondratek
commented
Feb 7, 2024
| if (channel == "default") { | ||
| // The published version WILL NOT be available right after the JetBrains approval. | ||
| // Instead, we control if and when we want to make it available. | ||
| // (Note: there is ~48h waiting time for JetBrains approval). |
There was a problem hiding this comment.
See docs on the approval process:
https://plugins.jetbrains.com/legal/approval-guidelines
mkondratek
force-pushed
the
mkondratek/chore/hide-by-default
branch
from
86067fe
to
b621ab7
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan