-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide stable releases by default #515
Conversation
|
||
channels.set( | ||
listOf( | ||
properties("pluginVersion").split('-').getOrElse(1) { "default" }.split('.').first())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.split('.').first()
This ☝️ was redundant. Historically, the plugin supported versions like 2.1.7-alpha.3
. It's no longer a case for us.
// The published version WILL NOT be available right after the JetBrains approval. | ||
// Instead, we control if and when we want to make it available. | ||
// (Note: there is ~48h waiting time for JetBrains approval). | ||
hidden.set(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵️♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (channel == "default") { | ||
// The published version WILL NOT be available right after the JetBrains approval. | ||
// Instead, we control if and when we want to make it available. | ||
// (Note: there is ~48h waiting time for JetBrains approval). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See docs on the approval process:
https://plugins.jetbrains.com/legal/approval-guidelines
86067fe
to
b621ab7
Compare
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test plan