fix: Missing context files #535
Conversation
mkondratek
force-pushed
the
mkondratek/fix/missing-context-files
branch
4 times, most recently
from
69839ec
to
8f8e060
Compare
| if (extensionMessage.chatID != null) { | ||
| if (prevLastMessage != null) { | ||
| if (lastMessage?.contextFiles != messages.lastOrNull()?.contextFiles) { | ||
| val index = restoredMessagesCount + extensionMessage.messages.count() - 2 |
There was a problem hiding this comment.
I was always confused by that - 2 but I finally get it.
Won't it be the same (but IMHO more easier to understand) if instead you will use messages.count() - 1?
There was a problem hiding this comment.
extensionMessage.messages always contains the full transcript of a given session.
Hence,
messages.count() - 1 is always the index of the last element
and
messages.count() - 2 is always the index of the element before the last element
That's all 😃
| commandId.displayName, | ||
| ), | ||
| chatSession.messages.count()) | ||
| chatSession.addMessageAtIndex( |
There was a problem hiding this comment.
Can we force shouldAddBlinkingCursor = true there?
It will guarantee that cursor started blinking even if there is no response from the agent yet, it will be more responsive in some scenarios (e.g restart of the agent, slow LLM, bad connectivity)
There was a problem hiding this comment.
ok, but I tested it with no interent connection and it does not show the cursor (removes it immedietaly).
cancellationToken.onFinished {
ApplicationManager.getApplication().invokeLater {
removeBlinkingCursor()
getLastMessage()?.onPartFinished()
}
}
cancellationToken removes it when there is not internet
| @@ -28,6 +28,8 @@ class AccordionSection(title: String) : JPanel() { | |||
| contentPanel.isVisible = true | |||
| toggleButton.text = createToggleButtonHTML(sectionTitle, false) | |||
| } | |||
| revalidate() | |||
There was a problem hiding this comment.
What scenario was broken without that?
mkondratek
force-pushed
the
mkondratek/fix/missing-context-files
branch
from
8f8e060
to
81333cd
Compare
| @@ -28,6 +28,7 @@ private constructor( | |||
| private val project: Project, | |||
| newSessionId: CompletableFuture<SessionId>, | |||
| private val internalId: String = UUID.randomUUID().toString(), | |||
| private val restoredMessagesCount: Int = 0 | |||
There was a problem hiding this comment.
It seems to be never updated, I guess it's not needed at all now?
mkondratek
force-pushed
the
mkondratek/fix/missing-context-files
branch
from
81333cd
to
41563ec
Compare
| project, | ||
| sessionId, | ||
| state.internalId!!, | ||
| restoredMessagesCount = state.messages.count()) |
There was a problem hiding this comment.
@pkukielka, pls take a look - the value is not updated, it's initialized here
mkondratek
force-pushed
the
mkondratek/fix/missing-context-files
branch
from
19269dc
to
b15e831
Compare
mkondratek
force-pushed
the
mkondratek/fix/missing-context-files
branch
from
77af739
to
00da372
Compare
Reattempt of #520.
Fixes https://github.com/sourcegraph/sourcegraph/issues/57378.
Fixes #328.
Test plan